Add KRUN_FS_ROOT_TAG define and document krun_set_root alternative#637
Merged
mtjhrc merged 1 commit intocontainers:mainfrom Apr 15, 2026
Merged
Add KRUN_FS_ROOT_TAG define and document krun_set_root alternative#637mtjhrc merged 1 commit intocontainers:mainfrom
KRUN_FS_ROOT_TAG define and document krun_set_root alternative#637mtjhrc merged 1 commit intocontainers:mainfrom
Conversation
Expose the virtiofs tag we use internally to krun_set_root() so that users are able to use it with APIs such as krun_add_virtiofs3() (recently added via containers#623). This way, they can gain control over the read-only state of the root file system (among other properties) without having to guess the tag to use. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
Collaborator
|
I'm not really a fan of adding this right now, users can already do Only problem is user has to know we use "/dev/root" in the default cmdline arguments for the kernel. Only addition I think we should consider is For libkrun 2.0 I think we should make the user always pass in the virtiofs tag to boot from explicitly, that is more obvious to the user and flexible. |
Collaborator
|
Also we could also add an explicit comment to |
d-e-s-o
force-pushed
the
topic/set-root-ro
branch
from
4ac0c50 to
4a7d366
Compare
d-e-s-o
changed the title
krun_set_root2() API to support read-only root filesystemsKRUN_FS_ROOT_TAG define and document krun_set_root alternative
Contributor
Author
|
Sure, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #623 added support for read-only mounts. It seems only consequent to also provide users with the ability to set read-only state for the root file system.
Introduce
krun_set_root2(), which extendskrun_set_root()with a read_only parameter to allow exposing the root filesystem as read-only to the guest. The originalkrun_set_root()now delegates to the new function withread_only=false, preserving the previous behavior.