Merged
Conversation
slp
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
So far, we were relying on the kernel to automatically shut down the VM after init exits. This works fine with the libkrunfw kernel, but gives a pretty ugly (though harmless) panic on upstream kernels. This can easily be avoiding by actually using the reboot() syscall to tell the kernel this is actually what we want to do. Do it after recording the exit code. Signed-off-by: Sergio Lopez <slp@redhat.com>
Collaborator
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces system shutdown logic to the init process by adding reboot headers and calling sync() and reboot() when a child process exits. The review feedback highlights several critical issues: the reboot call is placed inside a reaping loop which may cause premature shutdown if multiple children are present, the inclusion of redundant headers, the use of a restart command instead of power-off, and the absence of a safety loop to prevent kernel panics should the reboot syscall fail.
Collaborator
Author
|
I think we have a winner for the most useless Gemini review so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, we were relying on the kernel to automatically shut down the VM after init exits. This works fine with the libkrunfw kernel, but gives a pretty ugly (though harmless) panic on upstream kernels.
This can easily be avoiding by actually using the reboot() syscall to tell the kernel this is actually what we want to do. Do it after recording the exit code.