Remove builtin virtio-snd device#654
Merged
Merged
Conversation
mtjhrc
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
slp and
tylerfanelli
as code owners
The builtin virtio-snd device is not actively maintained or tested and has been superseded by vhost-user-snd. Remove it as part of the libkrun 2.0 breaking changes. This removes: - The virtio-snd device implementation (src/devices/src/virtio/snd/) - The 'snd' feature flag from all crates - The pipewire (pw) dependency from devices - The krun_set_snd_device() C API and KRUN_FEATURE_SND constant - CI references to the snd feature and libpipewire-0.3-dev Signed-off-by: Matej Hrica <mhrica@redhat.com>
slp
approved these changes
May 13, 2026
Collaborator
slp
left a comment
slp
left a comment
There was a problem hiding this comment.
Nice, let's drop some weight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builtin virtio-snd device is not very actively maintained and has been planned for removal in 2.0. For libkrun 2.0, user are expected to either use
vhost-user-sndusing the newly added vhost-user support or pipewire passthrough via virtio-gpu cross-domain.This removes: