rootless: set C variables also on shortcut #4911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
giuseppe
added a commit
to giuseppe/common
that referenced
this pull request
Jan 20, 2020
if CGO is enabled, make sure to use C.getenv instead of os.Getenv to read environment variables. It is required since rootless libpod joins the user namespace through Cgo. The variables set via C.setenv are not visible through os.Getenv, as the latter uses sync.Once to read the variables once. Requires: containers/podman#4911 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This was referenced Jan 20, 2020
Member
|
LGTM once things go green |
make sure the rootless env variables are set also when we are joining directly the user+mount namespace without creating a new process. It is required by pkg/unshare in containers/common. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
rootless-set-containers-env
branch
from
ecef477 to
ab7744d
Compare
Member
|
/lgtm |
Member
|
/test images |
2 similar comments
Member
|
/test images |
Member
Author
|
/test images |
Member
|
LGTM |
Member
Author
|
/test images |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure the rootless env variables are set also when we are joining
directly the user+mount namespace without creating a new process.
It is required by pkg/unshare in containers/common.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com