policy: fix missing mem_node_capacity metrics data. #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nri_policy_mem_node_capacity was never set due to an thinko in newSystemCollector() vs. SystemCollector.Update(). As a side effect memory node capacity was never exported among our metrics. Fix this now. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
changed the title
askervin
approved these changes
Nov 13, 2025
Collaborator
askervin
left a comment
askervin
left a comment
There was a problem hiding this comment.
LGTM.
Update() looks something to revisit in case of hot-plug, whether it is a new node or changed capacity. But that'll be later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nri_policy_mem_node_capacitywas never set due to an thinko in how things got set up innewSystemCollector()vs.SystemCollector.Update(). As a side effect memory node capacity was never exported among our metrics. This PR fixes that.