metrics: switch to OpenTelemetry based metrics collection. #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
devel/otel-metrics
branch
9 times, most recently
from
ccba60f to
7c23782
Compare
klihub
force-pushed
the
devel/otel-metrics
branch
2 times, most recently
from
e1b1f0a to
10b1b83
Compare
klihub
force-pushed
the
devel/otel-metrics
branch
from
10b1b83 to
338c215
Compare
klihub
force-pushed
the
devel/otel-metrics
branch
3 times, most recently
from
5ca4565 to
6e8f9c4
Compare
klihub
force-pushed
the
devel/otel-metrics
branch
from
6e8f9c4 to
548934f
Compare
askervin
reviewed
Dec 12, 2025
askervin
reviewed
Dec 12, 2025
marquiz
reviewed
Dec 12, 2025
| } | ||
|
|
||
| // Meter returns a meter for the given subsystem with the provided options. | ||
| func (mp *meterProvider) Meter(subsys string, options ...*meterOption) otelmetric.Meter { |
Collaborator
There was a problem hiding this comment.
OK, now I got this "re-create-meter-on-each-reconfigure". Somehow this feels clunky, excessive and "wrong".
I'd like to explore other alternatives, e.g. unregister callbacks of disabled subsystems or use dynamic "views" (WithView) or wrap the reader instead of meter
Collaborator
Author
There was a problem hiding this comment.
There is no way around the fact that a meter created by a nop provider can never be turned into one created by another provider. There is no other way than to re-create it.
askervin
reviewed
Dec 12, 2025
klihub
force-pushed
the
devel/otel-metrics
branch
3 times, most recently
from
78807ee to
c428d62
Compare
Add configuration options to chosing an OpenTelemetry metrics exporter. The chosen exporter itself should be configured via its well known environment variables. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Add support for OpenTelemetry based metrics collection and exporting. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Switch to otel metrics collection. Remove original metrics interface for policies. We won't proxy metrics registration and collection for them any more. Instead we expect them to directly register their own metrics for collection. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Implement OpenTelemetry metrics collection. Remove original prometheus metrics collector. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Implement OpenTelemetry metrics collection. Remove original prometheus metrics collector. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Remove the original prometheus-based metrics collector interface stubs. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Use the OpenTelemetry-based RDT metrics collector. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Remove the original, now unused prometheus-based metrics collection and remaining collectors. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Simplify OpenTelemetry tracing exporter configuration and unify it with metrics. We only accept "otlp-http" and "otlp-grpc" as exporters. All other configuration of the stock otel exporters can be done using their documented environment variables. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
devel/otel-metrics
branch
from
c428d62 to
6d6d83f
Compare
askervin
approved these changes
Jan 13, 2026
Collaborator
askervin
left a comment
askervin
left a comment
There was a problem hiding this comment.
LGTM (low-quality review due to my lack of knowledge on open telemetry)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR