Skip to content

resmgr: block cache save during initial sync.#640

Merged
askervin merged 1 commit intocontainers:mainfrom
klihub:fixes/block-cache-save
Mar 10, 2026
Merged

resmgr: block cache save during initial sync.#640
askervin merged 1 commit intocontainers:mainfrom
klihub:fixes/block-cache-save

Conversation

@klihub
Copy link
Copy Markdown
Collaborator

@klihub klihub commented Mar 9, 2026

When doing a mass release followed by a mass allocation during initial sync, don't save the cache after each operation. Instead block cache saves and unblock them once the bulk/batch operation is complete, saving the cache once in the end.

@klihub klihub requested review from askervin and fmuyassarov March 9, 2026 21:05
@askervin
Copy link
Copy Markdown
Collaborator

Looks good.

New methods still need to be added to mock objects for the unit tests to work. (This is what golangci-lint complains, too.)

@klihub klihub force-pushed the fixes/block-cache-save branch from 9078cd7 to 3660d73 Compare March 10, 2026 08:13
@klihub
Copy link
Copy Markdown
Collaborator Author

klihub commented Mar 10, 2026

Looks good.

New methods still need to be added to mock objects for the unit tests to work. (This is what golangci-lint complains, too.)

Argh... always tend to forget. Fixed.

@klihub klihub force-pushed the fixes/block-cache-save branch from 3660d73 to f546fbe Compare March 10, 2026 08:17
When doing a mass release followed by a mass allocation during
initial sync, don't save the cache after each operation. Instead
block cache saves and unblock them once the bulk/batch operation
is complete, saving the cache once in the end.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub force-pushed the fixes/block-cache-save branch from f546fbe to efc5001 Compare March 10, 2026 08:59
Copy link
Copy Markdown
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@askervin askervin merged commit 1dfcfde into containers:main Mar 10, 2026
9 checks passed
@klihub klihub deleted the fixes/block-cache-save branch March 11, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants