docs: fix README Python examples#193
Merged
Merged
Conversation
Align the README Python snippets with the current import path and CLI model card usage so users can follow the examples without hitting an import error or passing the model card in the wrong argument. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Jon Burdo <jon@jonburdo.com>
jonburdo
commented
Jul 6, 2026
|
|
||
| # Add the layers | ||
| oci_layers_on_top(model_dir, model_files) | ||
| oci_layers_on_top(model_dir, model_files, modelcard=modelcard) |
Collaborator
Author
There was a problem hiding this comment.
More consistent with the CLI example
uv run olot $IMAGE_DIR --modelcard tests/data/sample-model/README.md tests/data/sample-model/model.joblib
tarilabs
approved these changes
Jul 7, 2026
|
|
||
| ```python | ||
| from olot.basic import oci_layers_on_top | ||
| from olot.basics import oci_layers_on_top |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the README Python snippets with the current import path and CLI model card usage so users can follow the examples without hitting an import error or passing the model card in the wrong argument.