Fetch dep rpm updates #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
19 times, most recently
from
5b46bb8 to
8460ff5
Compare
Member
Author
|
Opening for review. @Luap99 @ashley-cui @baude @mheon PTAL. |
Member
Author
|
Err, never mind. spoke too soon. I see this in the logs: |
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
2 times, most recently
from
7b14fa1 to
a0f528e
Compare
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
2 times, most recently
from
1e649e5 to
d763332
Compare
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
2 times, most recently
from
12cd85f to
52134f7
Compare
Member
Author
|
Marking ready for review and hopefully merge. I split this into 2 commits, the first one to silence some shellcheck warnings. The latest x86_64 build log with PODMAN_PR_NUM set is at https://cirrus-ci.com/task/5427441096720384 in case anybody wants to examine. PTAL. |
Luap99
reviewed
Apr 7, 2025
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
from
29ceab4 to
7f2a0a3
Compare
lsm5
commented
Apr 8, 2025
Luap99
reviewed
Apr 8, 2025
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
2 times, most recently
from
c0002a3 to
e573cc7
Compare
Sometimes, the latest podman release rpm might need other dependencies like containers-common updated as well. This PR will fetch dependencies directly from koji regardless of bodhi status. container-selinux and crun will be fetched from the default distro tags while aardvark-dns, containers-common, and netavark will be fetched from sidetags owned by packit using `koji download-build ...`. Fedora release is fetched from the coreos base image itself. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
force-pushed
the
fetch-dep-rpm-updates
branch
from
e573cc7 to
4bba088
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
@baude @mheon @ashley-cui PTAL and hopefully merge. |
Member
|
LGTM |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the latest podman release rpm might need other dependencies like containers-common updated as well.
This PR will fetch dependencies directly from koji regardless of bodhi status.
aardvark-dns, containers-common, crun and netavark will be fetched from default distro tags as well as sidetags owned by packit using
koji download-build ....NOTE: container-selinux rpm currently is facing conflicts with selinux-policy so I've skipped it for now.