Clean up code, list containers #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwhahaha PTAL |
Merged
mwhahaha
reviewed
Nov 5, 2020
mwhahaha
requested changes
Nov 5, 2020
|
@mwhahaha: bors r+ |
* Reformat project with black formatter/style + isort * Rename __ALL__ to __all__ * Implement list_containers() + unit tests Signed-off-by: Jhon Honce <jhonce@redhat.com>
mwhahaha
reviewed
Nov 6, 2020
| def __init__(self, url, base="/v1.24/libpod", *args, | ||
| **kwargs): # pylint: disable-msg=W1113 | ||
| def __init__( | ||
| self, url, base="/v1.24/libpod", *args, **kwargs |
There was a problem hiding this comment.
pylint seems unhappy with this for whatever reason, but we can resolve that later in the black usage patch.
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make mwhahaha a reviewer |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__ALL__to__all__Fixes #21
Signed-off-by: Jhon Honce jhonce@redhat.com