Use black formatter #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should hold off on this until #38 lands, then it'll just be a tox env and documentation |
jwhonce
reviewed
Nov 6, 2020
| ## Testing | ||
| Depending on the size of your PR we will expect at a minimum unit tests. | ||
|
|
||
| Depending on the size of your PR we will expect at a minimum unit tests. |
There was a problem hiding this comment.
@mwhahaha Thanks for this work.
Given your coverage work and we're in the high 80's on coverage. How about putting a number on the unit test/coverage results? Won't merge if PR coverage falls below 85%?
There was a problem hiding this comment.
Sure we can raise that and document it
This change documents the usage of black as the prefered formatter for this project. Additionally it adds two tox targets that can be used to have black be invoked. * `tox -e black` will print out what would be changed * `tox -e black-format` will actually update the files with the code formatted Black is configured via pyproject.toml with a line-length of 100 and will skip string normalization Closes containers#28 Signed-off-by: Alex Schultz <aschultz@redhat.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change documents the usage of black as the prefered formatter for
this project. Additionally it adds two tox targets that can be used to
have black be invoked.
tox -e blackwill print out what would be changedtox -e black-formatwill actually update the files with the codeformatted
Black is configured via pyproject.toml with a line-length of 100 and
will skip string normalization
Closes #28
Signed-off-by: Alex Schultz aschultz@redhat.com