Remove the container in case of detach mode

[milanbalazs]

Currently if the detach=True and remove=True parameters are specified in the same command, the container is not deleted.

Reproduce the issue:

from podman import PodmanClient

uri = "unix:///run/user/1000/podman/podman.sock"

with PodmanClient(base_url=uri) as client:
    c = client.containers.run("nginx", deatch=True, remove=True, command="/bin/false")

    print(c.status)

With this change if the above parameters are provided then the container object is returned and the container removing (wait method is included) is started on a separated thread.

Fix for:

• Container is not deleted if detach=True and remove=True are specified #402

[rhatdan]

These options should be sent to the server, to tell it to remove the container when it is finished, I don't think it is needs to be done on the client side?

[milanbalazs]

These options should be sent to the server, to tell it to remove the container when it is finished, I don't think it is needs to be done on the client side?

I agree that would be an elegant solution, but based on the API documentation the described options are not implemented on server side (API):

• https://docs.podman.io/en/latest/_static/api.html#tag/containers/operation/ContainerStartLibpod

Currently the containers.start method handles only the detachKeys parameter and the API also waits only this query parameter:

podman-py/podman/domain/containers.py

Lines 388 to 398 in da8fca9

	def start(self, **kwargs) -> None:
	"""Start processes in container.
	Keyword Args:
	detach_keys: Override the key sequence for detaching a container (Podman only)
	"""
	response = self.client.post(
	f"/containers/{self.id}/start", params={"detachKeys": kwargs.get("detach_keys")}
	)
	response.raise_for_status()

In my opinion, if you would like to pass these parameters to server side (via API), then some changes are needed on server side as well (at least in the API component).

If it's enough to solve this issue on the client side, then my PR can solve it. It's up to you. :)

[rhatdan]

OK
LGTM

[inknos]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, milanbalazs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [inknos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment