reset: remove external containers on podman system reset

[flouthoc]

Following PR allows podman system reset to remove all the external containers with a safety prompt when --force is not provided. This makes sure that podman system reset performs a complete nuke of all the containers.

Attempts a feature patch for issue: #10755

Example

flouthoc@system:~/src/stable/glibc$ podman system reset
WARNING! This will remove:
        - all containers
        - all pods
        - all images
        - all build cache
WARNING! The following external containers will be purged:
	- dbfc83909cbb (busybox-working-container)
	- c37fb04008bd (busybox-working-container-1)
Are you sure you want to continue? [y/N] y

• --force silently removes everything without any prompt.
  Example 2

flouthoc@system:~/src/stable/glibc$ podman system reset --force

[flouthoc]

Added [NO TESTS NEEDED] for a check will add relevant tests after initial review if needed.

[flouthoc]

I think failing tests are flake. I'll re-kick CI

[vrothberg]

I have a weak preference to have only one prompt. In fact, to keep things as they are but in case there are external containers to display them as follows:

flouthoc@system:~/src/stable/glibc$ podman system reset

WARNING! This will remove:
        - all containers (5 external containers)
        - all pods
        - all images
        - all build cache
Are you sure you want to continue? [y/N] y

IMO, system reset is a "nuke all" but we already remove external containers with rmi -f $image.

[flouthoc]

@vrothberg Sure sounds good to me. Just a slight doubt how would human-users know about which external containers are getting purged. Its fine if it is generally acceptable that podman system reset will nuke everything.

[rhatdan]

I agree only give one prompt, but output the external containers as well.

[mheon]

/approve
Concur that a single prompt would be fine - we should just list the external containers before the existing "proceed" prompt

[TomSweeneyRedHat]

I'm not sure why the release test is failing with dev shouldn't be in the version for the main branch.... @edsantiago ?

[flouthoc]

@TomSweeneyRedHat Thanks resolved your feedback on latest commit.
@vrothberg @rhatdan @mheon Added a single prompt with list of external containers if any as suggested.

Example

flouthoc@system:~/src/stable/glibc$ podman system reset
WARNING! This will remove:
        - all containers
        - all pods
        - all images
        - all build cache
WARNING! Following External Containers will be purged
CONTAINER ID  NAME
c7d50cbfff74  busybox-working-container
3ab9923a9f8b  busybox-working-container-1
bd371cdddd29  busybox-working-container-2
Are you sure you want to continue? [y/N] y

[vrothberg]

Suggested change

	fmt.Println(`WARNING! The Following External Containers will be purged`)
	fmt.Println(`WARNING! The following external containers will be purged:`)

[vrothberg]

Thanks, @flouthoc!

Visually, I would find it more appealing if the the two lists would have the same format. Maybe something as below?

flouthoc@system:~/src/stable/glibc$ podman system reset
WARNING! This will remove:
        - all containers
        - all pods
        - all images
        - all build cache
WARNING! The following external containers will be purged:
        - c7d50cbfff74  (busybox-working-container)
        - 3ab9923a9f8b  (busybox-working-container-1)
        - bd371cdddd29  (busybox-working-container-2)
Are you sure you want to continue? [y/N] y

Let's wait how the others think.

[edsantiago]

I'm not sure why the release test is failing with dev shouldn't be in the version for the main branch.... @edsantiago ?

@TomSweeneyRedHat that happens when someone manually presses the "Trigger" button for that test, usually because they see that it didn't run and they believe it should run. It shouldn't. It's an optional test that doesn't actually run and shouldn't run. If you've read HHGTTG, it's the equivalent of a big button that, when pressed, lights up and says "do not press this button again".

[flouthoc]

@edsantiago Oh actually i triggered that test by mistake. 😢 😭

[rhatdan]

@flouthoc Make @vrothberg suggestion and then we can merge.

[flouthoc]

@vrothberg Updated with suggested changes in lastest commit

flouthoc@system:~/src/stable/glibc$ podman system reset
WARNING! This will remove:
        - all containers
        - all pods
        - all images
        - all build cache
WARNING! The following external containers will be purged:
	- dbfc83909cbb (busybox-working-container)
	- c37fb04008bd (busybox-working-container-1)
Are you sure you want to continue? [y/N] y

[vrothberg]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, mheon, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm