container create: fix --tls-verify parsing

[vrothberg]

Make sure that the value is only set if specified on the CLI. c/image
already defaults to true but if set in the system context, we'd skip
settings in the registries.conf.

Fixes: #11933
Signed-off-by: Valentin Rothberg rothberg@redhat.com

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[umohnani8]

LGTM

[TomSweeneyRedHat]

@vrothberg All kinds of unhappy tests

[vrothberg]

Updated. I moved the optional* code from Skopeo into c/common (already merged and Skopeo has been ported to it). The container-creation code is now using that code.

Other podman commands can later use that as well but I refrained from doing that in this PR.

[mtrmac]

ACK (but I only skimmed the diff very quickly).

[vrothberg]

@containers/podman-maintainers PTAL

[flouthoc]

LGTM

[Luap99]

Many commands have the --tls-verify flag, do they need to change too?

[rhatdan]

/lgtm

[vrothberg]

Many commands have the --tls-verify flag, do they need to change too?

Eventually, yes, at least for the sake of consistency. But I refrained from doing that now, see:

Other podman commands can later use that as well but I refrained from doing that in this PR.