remove github.com/docker/libnetwork dependency#15517
Merged
openshift-merge-robot merged 1 commit intocontainers:mainfrom Aug 30, 2022
Merged
remove github.com/docker/libnetwork dependency#15517openshift-merge-robot merged 1 commit intocontainers:mainfrom
openshift-merge-robot merged 1 commit intocontainers:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
tyler92
force-pushed
the
remove-libnetwork-dep
branch
from
89e5597 to
e72ec2f
Compare
Code from this dependency was replaced with a simple version. As a result Podman's memory consumption has been reduced by ~10%. [NO NEW TESTS NEEDED] Signed-off-by: Mikhail Khachayants <tyler92@inbox.ru>
tyler92
force-pushed
the
remove-libnetwork-dep
branch
from
e72ec2f to
b4f5a24
Compare
Contributor
Author
|
Please let me know if it is micro-optimization and if such commits won't be considered useful. |
Member
|
No this is great thank you very much @tyler92 |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, tyler92 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mheon
added
release-note-none
and removed
lgtm
Contributor
Author
Is something wrong or it's a mistake? |
Member
|
Don't know how LGTM/approved were removed, only wanted to get rid of the release-note-label-needed hold |
mheon
added
lgtm
github-actions
bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code from this dependency was replaced with a simple version. As a
result Podman's memory consumption has been reduced by ~10%.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?
Before changes:
After (see RSS section):