Clean up /var/tmp/ when using oci-archives when creating containers #19265
Conversation
openshift-ci
bot
added
release-note
approved
|
Replaces: #19201 |
contrib/tmpfile/podman.conf
Outdated
There was a problem hiding this comment.
Path in the comment must change as well.
There was a problem hiding this comment.
Waiting on repush, to make sure tests pass. Not sure how important this change would be.
contrib/tmpfile/podman.conf
Outdated
There was a problem hiding this comment.
Why only at boot? I feel like if you have a long running server we can clean these up much earlier. I would even say set this to 1 day.
There was a problem hiding this comment.
Well then you would have a risk of someone pulling an image and then systemd kills it.
These should only leak when something is killed, so it should not be that common.
There was a problem hiding this comment.
No that is not what tmpfiles does. It will only removes files that are not touched in the last X time.
The date field, when set, is used to decide what files to delete when cleaning. If a file or directory is older than the current time minus the age field, it is deleted.
So I don't see how systemd would ever delete files that are still in use by us.
There was a problem hiding this comment.
I don't see how you can use a timer with a glob to remove files?
There was a problem hiding this comment.
Yeah not 100% sure either, I don't have time to look into it but this change works as well so fine for me.
rhatdan
force-pushed
the
tmpfs
branch
3 times, most recently
from
cc71e6e to
66b82ee
Compare
containers We need to remove /var/tmp/container_images_* and /var/tmp/container_images_* which are podman temporary directories on each boot which are created when creating containers from oci-archive tarballs or other pull operations. Signed-off-by: Joe Doss <joe@solidadmin.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
Use this PR rather then #19305 |
|
@containers/podman-maintainers PTAL |
flouthoc
left a comment
flouthoc
left a comment
There was a problem hiding this comment.
LGTM
/lgtm
/approve
/hold
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Why is this revendoring the world? |
|
For some reason, containers/image would not update until I vendored the universe. |
rhatdan
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
4 participants
Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED]