Quadlet override service name #23449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
ygalblum
force-pushed
the
quadlet-override-service-name
branch
3 times, most recently
from
972e192 to
cd5616f
Compare
ygalblum
force-pushed
the
quadlet-override-service-name
branch
3 times, most recently
from
928964c to
22a2949
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ygalblum
force-pushed
the
quadlet-override-service-name
branch
from
22a2949 to
5f9bc48
Compare
Contributor
Author
|
@Luap99 this is the PR that completes the support for overriding the generated service name. In addition to the code changes, it required some adjustments to the tests in addition to some new tests |
Member
|
@ygalblum could you rebase and repush. |
ygalblum
force-pushed
the
quadlet-override-service-name
branch
from
5f9bc48 to
ac87f27
Compare
Contributor
Author
|
@rhatdan Done |
rhatdan
reviewed
Aug 7, 2024
pkg/systemd/quadlet/quadlet.go
Outdated
Member
There was a problem hiding this comment.
One enhancement would be to add a function unitInfo.Filename() and clean this up.
service.Filename=unitInfo.Filename()
Since this is replicated everywhere.
ygalblum
force-pushed
the
quadlet-override-service-name
branch
from
ac87f27 to
dee40bb
Compare
Add support for the ServiceName key for all unit types Extend the PodInfo struct into UnitInfo to consolidate all prepopulated data into a single map Use the NodesInfo map instead of the resourceName Update the UnitInfo in the convert function instead of returning it No need to replace extension anymore just remove it All e2e tests with dependencies on other Quadlet files moved to a separate section Add the capability of overriding the service name in the test Add e2e tests for the new functionality Adjust integration tests Update the MAN page Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
ygalblum
force-pushed
the
quadlet-override-service-name
branch
from
dee40bb to
795851e
Compare
Contributor
Author
|
@containers/podman-maintainers PTAL |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?
Yes