Skip to content

Conversation

@ricardobranco777
Copy link
Contributor

@ricardobranco777 ricardobranco777 commented Nov 7, 2025

Update 410-selinux test to handle new error message from runc 1.3.3. Otherwise it fails with:

# #|     FAIL: podman emits useful diagnostic on failure
# #| expected: 'Error.*: .*: \(failed to set\|write\) /proc/self/attr/keycreate.*' (using expr)
# #|   actual: 'Error: OCI runtime error: runc: runc create failed: unable to start container process: error during container init: write fsmount:fscontext:proc/self/attr/keycreate: invalid argument'

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

@ricardobranco777
Copy link
Contributor Author

Verification run: https://openqa.opensuse.org/tests/5436144

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When @Luap99's comments will be addressed, LGTM.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025
Signed-off-by: Ricardo Branco <rbranco@suse.de>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99, ricardobranco777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricardobranco777
Copy link
Contributor Author

The only failure in CI on Debian is unrelated to this PR and I don't think it's worthwhile to restart the whole thing:

- 420 |520| podman checkpoint/restore ip and mac handling in 4358ms

@openshift-merge-bot openshift-merge-bot bot merged commit fc5c29d into containers:main Nov 7, 2025
55 checks passed
@ricardobranco777 ricardobranco777 deleted the runc_133 branch November 7, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants