Skip to content

Conversation

@Honny1
Copy link
Member

@Honny1 Honny1 commented Nov 19, 2025

Allows the validatepr container to fetch dependencies from GitHub during validation by enabling host networking.

This PR fixes the error of make validatepr on macOS:

...
+ echo 'Running validation tooling'
Running validation tooling
++ awk '/MemTotal/ {print $2}' /proc/meminfo
+ mem=5009584
+ ((  5009584 < 3900000  ))
+ make validate
make[1]: Entering directory '/go/src/github.com/containers/podman'
VERSION=2.6.0 ./hack/install_golangci.sh
Installing golangci-lint v2.6.0 into ./bin/golangci-lint
golangci/golangci-lint info checking GitHub for tag 'v2.6.0'
golangci/golangci-lint info found version: 2.6.0 for v2.6.0/linux/arm64
golangci/golangci-lint info installed ./bin/golangci-lint
hack/golangci-lint.sh
Linting for GOOS=linux
+ ./bin/golangci-lint run --build-tags=apparmor,seccomp,selinux
pkg/selinux/selinux.go:4:2: could not import github.com/opencontainers/selinux/go-selinux (/root/go/pkg/mod/go.podman.io/storage@v1.61.1-0.20251112195944-4afce3558e66/layers.go:22:2: reading github.com/opencontainers/selinux/go.mod at revision v1.13.1: git ls-remote -q origin in /root/go/pkg/mod/cache/vcs/49bf5caa92b4f9ff8c1e2713127b5413597f3869c253c1159d7d4bf7be68beab: exit status 128:
	fatal: unable to access 'https://github.com/opencontainers/selinux/': Failed to connect to github.com port 443 after 1015 ms: Could not connect to server) (typecheck)
	"github.com/opencontainers/selinux/go-selinux"
	^
pkg/selinux/selinux.go:13:21: undefined: selinux (typecheck)
	processLabel, _ := selinux.KVMContainerLabels()
	                   ^
pkg/selinux/selinux.go:14:2: undefined: selinux (typecheck)
	selinux.ReleaseLabel(processLabel)
	^
pkg/selinux/selinux.go:24:21: undefined: selinux (typecheck)
	processLabel, _ := selinux.InitContainerLabels()
	                   ^
pkg/selinux/selinux.go:25:2: undefined: selinux (typecheck)
	selinux.ReleaseLabel(processLabel)
	^
pkg/selinux/selinux.go:30:15: undefined: selinux (typecheck)
	dcon, err := selinux.NewContext(cLabel)
	             ^
pkg/selinux/selinux.go:34:15: undefined: selinux (typecheck)
	scon, err := selinux.NewContext(processLabel)
	             ^
7 issues:
* typecheck: 7
make[1]: *** [Makefile:291: golangci-lint] Error 1
make[1]: Leaving directory '/go/src/github.com/containers/podman'
make: *** [Makefile:345: .validatepr] Error 2
gmake: *** [Makefile:335: validatepr] Error 2

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 19, 2025
@Honny1 Honny1 added the No New Tests Allow PR to proceed without adding regression tests label Nov 19, 2025
@Honny1
Copy link
Member Author

Honny1 commented Nov 19, 2025

Unrelated CI failure; fixed in #27562

@Honny1 Honny1 marked this pull request as ready for review November 19, 2025 14:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025
Allows the validatepr container to fetch dependencies from GitHub
during validation by enabling host networking.

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
@baude
Copy link
Member

baude commented Nov 19, 2025

sure, nice add.

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b9dc476 into containers:main Nov 20, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants