add bootc transports to os-apply#27999
Merged
Luap99 merged 2 commits intocontainers:mainfrom Feb 3, 2026
Merged
Conversation
baude
added
No New Tests
baude
force-pushed
the
applytransports
branch
from
1456f41 to
cd7a076
Compare
baude
force-pushed
the
applytransports
branch
from
cd7a076 to
0c43d13
Compare
ashley-cui
approved these changes
Jan 30, 2026
Member
ashley-cui
left a comment
ashley-cui
left a comment
There was a problem hiding this comment.
one small docs comment, but other than that, I've tested things manually and it works, so LGTM
Member
|
@baude all kinds of test unhappiness |
jankaluza
reviewed
Feb 2, 2026
jankaluza
reviewed
Feb 2, 2026
Luap99
reviewed
Feb 2, 2026
now that we use `bootc switch` for changing out-of-band updates, we can consider also using some of their supported transports. * containers-storage * oci * oci-archive * registry RUN-3963 Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
force-pushed
the
applytransports
branch
from
0c43d13 to
f4138d3
Compare
Luap99
reviewed
Feb 2, 2026
cmd/podman/machine/os/apply.go
Outdated
| // We also accept an URI so ignore ShellCompDirectiveNoFileComp and use the default one instead to get file paths completed by the shell. | ||
| return images, cobra.ShellCompDirectiveDefault | ||
| case 1: | ||
| cobra.CompDebugln("here", true) |
Member
There was a problem hiding this comment.
sorry I left this debug in here, if you repush please drop it
baude
force-pushed
the
applytransports
branch
from
b12c74b to
2932ad7
Compare
Fixups for autocomplete for machine commands. This was authored by Paul Holzinger. Thank you very much! Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
force-pushed
the
applytransports
branch
from
2932ad7 to
40b2a58
Compare
Member
|
Other than @Luap99 's comment on debug, LGTM |
Member
|
LGTM. The test failure is most likely temporary issue, but I cannot restart tests myself :-/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now that we use
bootc switchfor changing out-of-band updates, we can consider also using some of their supported transports.RUN-3963
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?