Skip to content

Comments

docs: Update PR approval process to use GitHub's native review system#28086

Merged
Luap99 merged 1 commit intocontainers:mainfrom
timcoding1988:pr-approval-doc-updates
Feb 16, 2026
Merged

docs: Update PR approval process to use GitHub's native review system#28086
Luap99 merged 1 commit intocontainers:mainfrom
timcoding1988:pr-approval-doc-updates

Conversation

@timcoding1988
Copy link
Collaborator

@timcoding1988 timcoding1988 commented Feb 12, 2026

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

@timcoding1988 timcoding1988 changed the title updating pr review and approval process docs: Update PR approval process to use GitHub's native review system Feb 12, 2026
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@timcoding1988 timcoding1988 added the documentation Issue or fix is in project documentation label Feb 12, 2026
CONTRIBUTING.md Outdated
The Podman project uses GitHub's native review system for PR approval and merging.

* ``/close``: Closes an issue or PR.
* **Requesting Review**: When your PR is ready for review, use GitHub's "Reviewers" feature in the right sidebar to request reviews from maintainers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is a good advice, new people have no idea who to request and I rather not want them request me all the time. I think we do not need to mention this, reviewers are supposed to check on PRs themselves

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention tagging containers/podman-maintainers in a comment instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this works? I think teams cannot be pinged as outside person (likely due spam problem)

Organization members can send a notification to an entire team by mentioning the team's name. Teams can only be made up of members of your organization, outside collaborators are unable to be on a team.

Visible teams can be viewed and @mentioned by every organization member.

https://docs.github.com/en/organizations/organizing-members-into-teams/about-teams

If you are not logged in you do not see the team mention as clickable, i.e. just log at this PR in incognito tab and look at the first packit comment

@timcoding1988 timcoding1988 force-pushed the pr-approval-doc-updates branch 2 times, most recently from f1fa2ce to 20dd7fc Compare February 13, 2026 14:45
@timcoding1988 timcoding1988 force-pushed the pr-approval-doc-updates branch 5 times, most recently from cb326f3 to b3d65ab Compare February 13, 2026 15:09
@timcoding1988 timcoding1988 changed the title docs: Update PR approval process to use GitHub's native review system [ci-skip] docs: Update PR approval process to use GitHub's native review system Feb 13, 2026
@timcoding1988 timcoding1988 force-pushed the pr-approval-doc-updates branch 2 times, most recently from 8383675 to f094a2d Compare February 13, 2026 15:16
@Luap99 Luap99 changed the title [ci-skip] docs: Update PR approval process to use GitHub's native review system docs: Update PR approval process to use GitHub's native review system Feb 13, 2026
@Luap99
Copy link
Member

Luap99 commented Feb 13, 2026

Please do no use ci skip for this, simply just lets never use it. We need spellcheck and other basic things to always run.

@timcoding1988 timcoding1988 force-pushed the pr-approval-doc-updates branch from f094a2d to 1a96d72 Compare February 13, 2026 15:46
@timcoding1988
Copy link
Collaborator Author

Please do no use ci skip for this, simply just lets never use it. We need spellcheck and other basic things to always run.

@Luap99 sure. re-commit this so it will trigger the whole flow

@TomSweeneyRedHat
Copy link
Member

All kinds of Red Unhappy tests here @timcoding1988

@timcoding1988 timcoding1988 force-pushed the pr-approval-doc-updates branch from 1a96d72 to 8530de4 Compare February 16, 2026 14:10
@timcoding1988 timcoding1988 force-pushed the pr-approval-doc-updates branch 2 times, most recently from d2afd53 to f64cdcb Compare February 16, 2026 16:22
@timcoding1988
Copy link
Collaborator Author

All kinds of Red Unhappy tests here @timcoding1988

@TomSweeneyRedHat rebased my branch. pr should be good

Signed-off-by: Tim Zhou <tizhou@redhat.com>
@timcoding1988 timcoding1988 force-pushed the pr-approval-doc-updates branch from f64cdcb to 751d6f7 Compare February 16, 2026 16:32
@mheon
Copy link
Member

mheon commented Feb 16, 2026

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 merged commit 8c1cbdc into containers:main Feb 16, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issue or fix is in project documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants