docs: Update PR approval process to use GitHub's native review system#28086
docs: Update PR approval process to use GitHub's native review system#28086Luap99 merged 1 commit intocontainers:mainfrom
Conversation
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
CONTRIBUTING.md
Outdated
| The Podman project uses GitHub's native review system for PR approval and merging. | ||
|
|
||
| * ``/close``: Closes an issue or PR. | ||
| * **Requesting Review**: When your PR is ready for review, use GitHub's "Reviewers" feature in the right sidebar to request reviews from maintainers. |
There was a problem hiding this comment.
I don't think that is a good advice, new people have no idea who to request and I rather not want them request me all the time. I think we do not need to mention this, reviewers are supposed to check on PRs themselves
There was a problem hiding this comment.
removed this.
There was a problem hiding this comment.
Maybe mention tagging containers/podman-maintainers in a comment instead?
There was a problem hiding this comment.
Does this works? I think teams cannot be pinged as outside person (likely due spam problem)
Organization members can send a notification to an entire team by mentioning the team's name. Teams can only be made up of members of your organization, outside collaborators are unable to be on a team.
Visible teams can be viewed and @mentioned by every organization member.
https://docs.github.com/en/organizations/organizing-members-into-teams/about-teams
If you are not logged in you do not see the team mention as clickable, i.e. just log at this PR in incognito tab and look at the first packit comment
f1fa2ce to
20dd7fc
Compare
cb326f3 to
b3d65ab
Compare
8383675 to
f094a2d
Compare
|
Please do no use ci skip for this, simply just lets never use it. We need spellcheck and other basic things to always run. |
f094a2d to
1a96d72
Compare
@Luap99 sure. re-commit this so it will trigger the whole flow |
|
All kinds of Red Unhappy tests here @timcoding1988 |
1a96d72 to
8530de4
Compare
d2afd53 to
f64cdcb
Compare
@TomSweeneyRedHat rebased my branch. pr should be good |
Signed-off-by: Tim Zhou <tizhou@redhat.com>
f64cdcb to
751d6f7
Compare
|
LGTM |
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?