Skip to content

Fixes for running the e2e testsuite on architectures other than amd64#28266

Merged
Luap99 merged 4 commits intocontainers:mainfrom
ricardobranco777:arm64e2e
Mar 12, 2026
Merged

Fixes for running the e2e testsuite on architectures other than amd64#28266
Luap99 merged 4 commits intocontainers:mainfrom
ricardobranco777:arm64e2e

Conversation

@ricardobranco777
Copy link
Contributor

@ricardobranco777 ricardobranco777 commented Mar 12, 2026

Fixes #28255

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

@ricardobranco777
Copy link
Contributor Author

openQA verification runs on aarch64:

Note: The above were run applying this patch on podman 5.8.0. We had to skip test/e2e/run_aardvark_test.go because it doesn't apply cleanly.

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a SkipIfNotAMD64 function in podman/test/e2e/common_test.go and use that instead? This would improve readability.

@Luap99
Copy link
Member

Luap99 commented Mar 12, 2026

Also can you file issues for the container images that only work on amd64. And then add a link to the issue next to the skip. This sounds like something we should fix eventually though certainly not as part of this PR.

And I thought we run aarch64 tests already but turns out this is only for system tests. I guess it would also make sense to add one upstream CI run at least for aarch64 e2e tests

Some architectures (i.e., arm64) do not implement the link(2) system
call and ln(1) uses linkat(2) instead.

Use the names array to block both syscalls so the tests works on all
architectures.

Signed-off-by: Ricardo Branco <rbranco@suse.de>
Signed-off-by: Ricardo Branco <rbranco@suse.de>
Signed-off-by: Ricardo Branco <rbranco@suse.de>
@ricardobranco777
Copy link
Contributor Author

ricardobranco777 commented Mar 12, 2026

Also can you file issues for the container images that only work on amd64. And then add a link to the issue next to the skip. This sounds like something we should fix eventually though certainly not as part of this PR.

New issues opened:

Signed-off-by: Ricardo Branco <rbranco@suse.de>
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@ricardobranco777 ricardobranco777 marked this pull request as ready for review March 12, 2026 14:23
@ricardobranco777
Copy link
Contributor Author

Verification run for latest changes:

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Luap99 Luap99 merged commit 8960c6b into containers:main Mar 12, 2026
56 of 58 checks passed
@ricardobranco777 ricardobranco777 deleted the arm64e2e branch March 12, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some podman e2e tests can't be run on arches other than x86_64

3 participants