api: fix missing return after error in SystemCheck handler#28352
Merged
Honny1 merged 1 commit intocontainers:mainfrom Mar 25, 2026
Merged
Conversation
In the SystemCheck HTTP handler, when parsing the unreferenced_layer_max_age query parameter fails, the error response is sent but execution continues to `unreferencedLayerMaximumAge = &duration` where `duration` is the zero value. This causes the system check to run with a zero duration instead of returning the 400 error to the client. Add the missing `return` after the error response. Fixes containers#28350 Signed-off-by: crawfordxx <crawfordxx@users.noreply.github.com>
github-actions
bot
added
the
kind/api-change
danishprakash
approved these changes
Mar 24, 2026
Member
danishprakash
left a comment
danishprakash
left a comment
There was a problem hiding this comment.
Change LGTM, but it might need a no-new-test label to be added.
Honny1
added
the
No New Tests
Honny1
approved these changes
Mar 24, 2026
Member
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
LGTM, Thanks!
Added label No New Tests and rerun tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
pkg/api/handlers/libpod/system.go, theSystemCheckHTTP handlerparses the
unreferenced_layer_max_agequery parameter viatime.ParseDuration. When parsing fails,utils.Erroris called tosend a 400 response, but execution falls through to:
where
durationis the zero value from the failed parse. This meansthe system check runs with a zero age limit instead of returning the
error to the client.
Add the missing
returnafter the error response.Fixes #28350