Skip to content

Add a Status filter to podman quadlet list #28369#28382

Merged
mheon merged 1 commit intocontainers:mainfrom
himgov:issue/28369
Mar 30, 2026
Merged

Add a Status filter to podman quadlet list #28369#28382
mheon merged 1 commit intocontainers:mainfrom
himgov:issue/28369

Conversation

@himgov
Copy link
Copy Markdown
Contributor

@himgov himgov commented Mar 26, 2026

Fixes: #28369

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • [ x] Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • [ x] Tests have been added/updated (or no tests are needed)
  • [ x] Documentation has been updated (or no documentation changes are needed)
  • [ x] All commits pass make validatepr (format/lint checks)
  • [ x] Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

Comment thread cmd/podman/common/completion.go Outdated
@packit-as-a-service
Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

himgov added a commit to himgov/podman that referenced this pull request Mar 26, 2026
Signed-off-by: Himanshu Jaiswal <himanshu.bw5@gmail.com>
himgov added a commit to himgov/podman that referenced this pull request Mar 26, 2026
Signed-off-by: Himanshu Jaiswal <himanshu.bw5@gmail.com>
Copy link
Copy Markdown
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look good, but I have one question about the completion. Also, please squash your commits. As the author, you can rerun the GitHub/Cirrus CI.

Comment thread cmd/podman/common/completion.go Outdated
Adds --filter status=<value> support to podman quadlet list.
Also adds shell completion for the status filter values.

Signed-off-by: Himanshu Jaiswal <himanshu.bw5@gmail.com>
@himgov himgov requested a review from Honny1 March 30, 2026 07:16
Copy link
Copy Markdown
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@Honny1
Copy link
Copy Markdown
Member

Honny1 commented Mar 30, 2026

PTAL @containers/podman-maintainers

@mheon
Copy link
Copy Markdown
Member

mheon commented Mar 30, 2026

LGTM

@mheon mheon merged commit 9bea6e7 into containers:main Mar 30, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Status filter to podman quadlet list

3 participants