fix(#28429): OCIRuntime field in SpecGenerator is ignored when called through HTTP Rest API#28454
Open
aadi58002 wants to merge 1 commit intocontainers:mainfrom
Open
fix(#28429): OCIRuntime field in SpecGenerator is ignored when called through HTTP Rest API#28454aadi58002 wants to merge 1 commit intocontainers:mainfrom
aadi58002 wants to merge 1 commit intocontainers:mainfrom
Conversation
4 tasks
Luap99
requested changes
Apr 9, 2026
Member
Luap99
left a comment
There was a problem hiding this comment.
Thanks for the PR, please squash the commits into one and give it a proper commit message, the Fixes: #28429 part should be at the end of the body not the title.
aadi58002
added a commit
to aadi58002/podman
that referenced
this pull request
Apr 9, 2026
…iners#28454) Signed-off-by: aadi58002 <aadi58002@gmail.com>
aadi58002
added a commit
to aadi58002/podman
that referenced
this pull request
Apr 9, 2026
…iners#28454) Signed-off-by: aadi58002 <aadi58002@gmail.com>
Member
|
@aadi58002 please run the API tests locally, as long as they fail we cannot merge |
…iners#28454) Signed-off-by: aadi58002 <aadi58002@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #28429in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Fixes: #28429
Does this PR introduce a user-facing change?