Skip to content

fix(#28429): OCIRuntime field in SpecGenerator is ignored when called through HTTP Rest API#28454

Open
aadi58002 wants to merge 1 commit intocontainers:mainfrom
aadi58002:main
Open

fix(#28429): OCIRuntime field in SpecGenerator is ignored when called through HTTP Rest API#28454
aadi58002 wants to merge 1 commit intocontainers:mainfrom
aadi58002:main

Conversation

@aadi58002
Copy link
Copy Markdown

@aadi58002 aadi58002 commented Apr 7, 2026

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #28429 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Fixes: #28429

Does this PR introduce a user-facing change?

None

Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please squash the commits into one and give it a proper commit message, the Fixes: #28429 part should be at the end of the body not the title.

aadi58002 added a commit to aadi58002/podman that referenced this pull request Apr 9, 2026
aadi58002 added a commit to aadi58002/podman that referenced this pull request Apr 9, 2026
@aadi58002 aadi58002 requested a review from Luap99 April 12, 2026 04:01
@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Apr 13, 2026

@aadi58002 please run the API tests locally, as long as they fail we cannot merge

Copy link
Copy Markdown
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 enabled auto-merge April 14, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OCIRuntime field in SpecGenerator is ignored

3 participants