Feat/container annotation filter#28641
Open
jiwahn wants to merge 1 commit into
Open
Conversation
Honny1
requested changes
May 5, 2026
Member
Honny1
left a comment
There was a problem hiding this comment.
Thanks, I have some comments. First, please also update the Swagger documentation. Then I would like to see some tests that will test negated annotations, and the last thing is, please squash commits.
39c934d to
5e890eb
Compare
|
Cockpit tests failed for commit 5e890eb. @martinpitt, @jelly, @mvollmer please check. |
Signed-off-by: Jiwoo Ahn <ikwydls1314@gmail.com>
5e890eb to
ec583fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?
Related Issuse
Resolves #28562
Changes
cmd/podman/common/completion.go:Adds annotation= completion for podman ps --filter and splits out a container-prune-specific filter completion helper that includes annotation=.cmd/podman/containers/prune.go: Updates podman container prune --filter to use the container-prune-specific completion helper.docs/source/markdown/options/filter.container.md: Documents annotation and annotation! as supported container filters.docs/source/markdown/podman-container-prune.1.md: Documents annotation-based filters for podman container prune.docs/source/markdown/podman-ps.1.md.in: Adds an annotation filter example for podman ps and notes that annotation filters are not supported for external containers.pkg/domain/filters/containers.go: Implements annotation and annotation! filtering for container list/prune operations and rejects them for external containers.test/e2e/prune_test.go: Adds an e2e test for pruning containers by annotation.test/e2e/ps_test.go: Adds e2e coverage for annotation / annotation! filters in podman ps and verifies rejection for external containers.