container start: fix regression when using name

[vrothberg]

When starting a container by using its name as a reference, we should
print the name instead of the ID. We regressed on this behaviour
with commit b412448 which made it into Podman v1.6.2.

Kudos to openSUSE testing for catching it. To prevent future
regressions, extend the e2e tests to check the printed container
name/ID.

Reported-by: @sysrich
Signed-off-by: Valentin Rothberg rothberg@redhat.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

@mheon @baude that's currently blocking openSUSE.

@sysrich, you could downstream patch it until the next release. Podman v1.6.3 was just released yesterday, so I think it'll take a while until the next release.

[TomSweeneyRedHat]

LGTM

[mheon]

@vrothberg Technically it was 1.6.3 RC1, so we can land this in the branch for 1.6.3 final

[vrothberg]

@vrothberg Technically it was 1.6.3 RC1, so we can land this in the branch for 1.6.3 final

@sysrich noticed that too ... I must have missed a coffee or two :^) I'll tackle the unhappy CI now.

[vrothberg]

Remote tests didn't like it. The remote client always returns the full ID, so we're skipping the specific checks in the e2e tests. It would be ideal to have both clients return the same output but this seems like a bigger change - it also pre-dates the regression and this PR.

[vrothberg]

We're green. @mheon @baude @rhatdan PTAL

[rhatdan]

/lgtm