Skip to content

PullOptions should work for rootless users also#1241

Merged
flouthoc merged 1 commit intocontainers:mainfrom
rhatdan:zstd
May 17, 2022
Merged

PullOptions should work for rootless users also#1241
flouthoc merged 1 commit intocontainers:mainfrom
rhatdan:zstd

Conversation

@rhatdan
Copy link
Copy Markdown
Member

@rhatdan rhatdan commented May 16, 2022

Also add interfaces to allow callers to see the pull options.

While experimenting with pushing and pulling with zstd, I found
that storage pulloptions were not being used in rootless mode.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@rhatdan
Copy link
Copy Markdown
Member Author

rhatdan commented May 16, 2022

Also add interfaces to allow callers to see the pull options.

While experimenting with pushing and pulling with zstd, I found
that storage pulloptions were not being used in rootless mode.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc flouthoc merged commit 6934beb into containers:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants