Skip to content

Cirrus: use latest fedora and ubuntu releases#1248

Merged
cevich merged 1 commit intocontainers:mainfrom
lsm5:bump-fedora-ubuntu-images
Jun 1, 2022
Merged

Cirrus: use latest fedora and ubuntu releases#1248
cevich merged 1 commit intocontainers:mainfrom
lsm5:bump-fedora-ubuntu-images

Conversation

@lsm5
Copy link
Copy Markdown
Member

@lsm5 lsm5 commented May 27, 2022

bump fedora release to 36
bump fedora prior to 35
bump ubuntu release to 22.04

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented May 27, 2022

depends on containers/automation_images#134

@lsm5 lsm5 requested a review from cevich May 27, 2022 12:45
@lsm5 lsm5 force-pushed the bump-fedora-ubuntu-images branch 2 times, most recently from fd7946b to 5b0c212 Compare May 27, 2022 14:55
Copy link
Copy Markdown
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsm5 lsm5 changed the title [WIP - DO NOT MERGE] Cirrus: use latest fedora and ubuntu releases Cirrus: use latest fedora and ubuntu releases May 31, 2022
@cevich
Copy link
Copy Markdown
Member

cevich commented May 31, 2022

I'm wondering if the failures here are due to the golang 1.18 update, since F35 tests are passing fine. Might need to bring in someone who knows this code/golang better than I.

@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Jun 1, 2022

i can try running those tests on rawhide

@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Jun 1, 2022

@cevich i can see it on rawhide. How about I revert the fedora part and only do ubuntu in this PR ?

@cevich
Copy link
Copy Markdown
Member

cevich commented Jun 1, 2022

How about I revert the fedora part and only do ubuntu in this PR ?

I wouldn't recommend it. My experience is that actually increases the burden since development efforts writ large continue to introduce more challenges and further divergence between the new and separated environment (Fedora in this case). So I would recommend the opposite, get the Fedora "problems" fixed as quickly as possible. Smash the red button, and call in all the willing help to address the issues. Then keep smashing that 'panic' button until the issues are resolved. The longer they go on, "hidden" in a single PR, the harder and longer they will take to fix.

@nalind
Copy link
Copy Markdown
Member

nalind commented Jun 1, 2022

Try rebasing on top of the just-merged #1250?

bump fedora release to 36
bump fedora prior to 35
bump ubuntu release to 22.04

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5 lsm5 force-pushed the bump-fedora-ubuntu-images branch from 5b0c212 to 0de5a4e Compare June 1, 2022 15:21
@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Jun 1, 2022

thanks @nalind !!

@cevich good to go

@cevich
Copy link
Copy Markdown
Member

cevich commented Jun 1, 2022

Yay! Thanks @nalind !

@cevich cevich merged commit 1fcdc9b into containers:main Jun 1, 2022
@lsm5 lsm5 deleted the bump-fedora-ubuntu-images branch June 1, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants