storage.conf: respect CONTAINERS_STORAGE_CONF env#1249
Merged
rhatdan merged 2 commits intocontainers:mainfrom Jun 1, 2022
Merged
storage.conf: respect CONTAINERS_STORAGE_CONF env#1249rhatdan merged 2 commits intocontainers:mainfrom
rhatdan merged 2 commits intocontainers:mainfrom
Conversation
CONTAINERS_STORAGE_CONF env var should overwrite the default path even for the first config load at init time. Fixes containers/podman#14267 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Using init in libs is bad. init() has to be run every time the application which imports this package starts. This slows down startup time even if the application will never use this code path. Instead use a sync.Once to only the config when it is required. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
|
LGTM. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTAINERS_STORAGE_CONF env var should overwrite the default path even
for the first config load at init time.
Fixes containers/podman#14267
types: do not load storage.conf at init time
Using init in libs is bad. init() has to be run every time the
application which imports this package starts. This slows down startup
time even if the application will never use this code path.
Instead use a sync.Once to only the config when it is required.