idtools: add lookup by UID with libsubid#1265
Merged
vrothberg merged 1 commit intocontainers:mainfrom Jun 16, 2022
Merged
Conversation
We lost this feature when we moved to using libsubid for looking up user additional ranges. If the lookup using the username fails then attempt again using the UID, since /etc/subuid and /etc/subgid allow that. Closes: containers#1264 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
vrothberg
reviewed
Jun 16, 2022
Member
vrothberg
left a comment
vrothberg
left a comment
There was a problem hiding this comment.
LGTM
Any chance we can add a regression test?
Member
Author
that would require a system configuration change since we are going through libsubid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We lost this feature when we moved to using libsubid for looking up
user additional ranges.
If the lookup using the username fails then attempt again using the
UID, since /etc/subuid and /etc/subgid allow that.
Closes: #1264
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com