Switch to golang native error wrapping#1282
Merged
rhatdan merged 2 commits intocontainers:mainfrom Jul 11, 2022
Merged
Conversation
saschagrunert
force-pushed
the
errors
branch
5 times, most recently
from
9f9f4e2 to
58a32f7
Compare
We now use the golang error wrapping format specifier `%w` instead of the deprecated github.com/pkg/errors package. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
changed the title
Member
Author
|
Ready for review, PTAL @containers/storage-maintainers |
rhatdan
approved these changes
Jul 7, 2022
Member
rhatdan
left a comment
rhatdan
left a comment
There was a problem hiding this comment.
LGTM
@nalind @giuseppe @vrothberg @flouthoc PTAL
Member
Member
|
@saschagrunert could you rebase just to be extra sure we don't miss anything? Feel free to merge once green. |
Member
Author
|
I missed the rebase because of my PTO yesterday, hope nothing broke. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use the golang error wrapping format specifier
%winstead of the deprecated github.com/pkg/errors package.