Skip to content

Do not error if no default storage.conf exists#1287

Merged
rhatdan merged 1 commit intocontainers:mainfrom
saschagrunert:err-not-exist
Jul 14, 2022
Merged

Do not error if no default storage.conf exists#1287
rhatdan merged 1 commit intocontainers:mainfrom
saschagrunert:err-not-exist

Conversation

@saschagrunert
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert commented Jul 14, 2022

This allows consumers of this library to rely on the in-memory default rather than requiring a storage.conf.

Refers to #1279 (1f647d9) and 1f647d9#r920899670

cc @giuseppe

This allows consumers of this library to rely on the in-memory default
rather than requiring a storage.conf.

Refers to containers#1279 and
1f647d9

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert changed the title Do not error if no storage.conf exists Do not error if no default storage.conf exists Jul 14, 2022
@saschagrunert
Copy link
Copy Markdown
Member Author

@containers/storage-maintainers PTAL

Copy link
Copy Markdown
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@giuseppe @rhatdan PTAL

Copy link
Copy Markdown
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit fc9b0ff into containers:main Jul 14, 2022
@saschagrunert saschagrunert deleted the err-not-exist branch July 14, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants