Skip to content

diff: create missing layers dirs with 0755#1289

Merged
rhatdan merged 1 commit intocontainers:mainfrom
giuseppe:mkdir-missing-dirs-0755
Jul 14, 2022
Merged

diff: create missing layers dirs with 0755#1289
rhatdan merged 1 commit intocontainers:mainfrom
giuseppe:mkdir-missing-dirs-0755

Conversation

@giuseppe
Copy link
Copy Markdown
Member

if the parent directory is missing when creating a directory or
extracting a file from the tarball, then create the missing parent
directories with mode 0755 instead of 0600 so that a container can run
with uid != 0.

Closes: #1288

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

if the parent directory is missing when creating a directory or
extracting a file from the tarball, then create the missing parent
directories with mode 0755 instead of 0600 so that a container can run
with uid != 0.

Closes: containers#1288

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 91e4d51 into containers:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If layer is missing leading directory component(s), they get 0600 permission

4 participants