Cleanup handling of default driver name, when storage.conf has drivername=""#486
Closed
rhatdan wants to merge 1 commit intocontainers:masterfrom
Closed
Cleanup handling of default driver name, when storage.conf has drivername=""#486rhatdan wants to merge 1 commit intocontainers:masterfrom
rhatdan wants to merge 1 commit intocontainers:masterfrom
Conversation
rhatdan
changed the title
rhatdan
force-pushed
the
driver
branch
3 times, most recently
from
aaad2f3 to
9a03161
Compare
nalind
reviewed
Dec 9, 2019
store.go
Outdated
| } | ||
| name, err := drivers.GetDefaultDriverName(options) | ||
| if err != nil { | ||
| fmt.Print(err) |
Member
There was a problem hiding this comment.
Should the error be returned here, too?
Member
Author
There was a problem hiding this comment.
The errors above for parsing the UID Maps were just printing errors, so I was matching, but I am fine with returning an error. Problem is ReloadConfigurationFile currently does not return errors, so this would need to be an API Breaking change.
rhatdan
force-pushed
the
driver
branch
6 times, most recently
from
4c1f0dc to
61005ae
Compare
If the user specifies drivername="" in the storage.conf then we default to the first driver name based on priority list, usually overla. The problem with this, is now the storage.conf file has options that are driver specific. The code does not catch this so ends up looking for a driver name of "", and finds no matching options. This code will set the drivername that the storage layer would choose earlies, so that storage will get the correct options out of the config file. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Member
Author
|
This does not seem to be possible, without a lot of horrible hacking. So I am going to give up and tell users to specify the driver in the storage name. |
Luap99
added a commit
to Luap99/container-libs
that referenced
this pull request
Mar 4, 2026
The option logic was chnaged in the prior commit to handle the case without driver name properly. Based on the comment in [1] the reason we had this warning was only because of this special option handling. [1] containers/storage#486 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/container-libs
that referenced
this pull request
Mar 4, 2026
The option logic was chnaged in the prior commit to handle the case without driver name properly. Based on the comment in [1] the reason we had this warning was only because of this special option handling. [1] containers/storage#486 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/container-libs
that referenced
this pull request
Mar 5, 2026
The option logic was chnaged in the prior commit to handle the case without driver name properly. Based on the comment in [1] the reason we had this warning was only because of this special option handling. [1] containers/storage#486 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/container-libs
that referenced
this pull request
Mar 5, 2026
The option logic was chnaged in the prior commit to handle the case without driver name properly. Based on the comment in [1] the reason we had this warning was only because of this special option handling. [1] containers/storage#486 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/container-libs
that referenced
this pull request
Mar 11, 2026
The option logic was chnaged in the prior commit to handle the case without driver name properly. Based on the comment in [1] the reason we had this warning was only because of this special option handling. [1] containers/storage#486 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/container-libs
that referenced
this pull request
Mar 11, 2026
The option logic was chnaged in the prior commit to handle the case without driver name properly. Based on the comment in [1] the reason we had this warning was only because of this special option handling. [1] containers/storage#486 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user specifies drivername="" in the storage.conf
then we default to the first driver name based on priority list, usually
overla.
The problem with this, is now the storage.conf file has options that are
driver specific. The code does not catch this so ends up looking for a driver
name of "", and finds no matching options.
This code will set the drivername that the storage layer would choose earlies,
so that storage will get the correct options out of the config file.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com