Set default to overlay from storage.conf#870
Merged
rhatdan merged 1 commit intocontainers:masterfrom Apr 3, 2021
Merged
Conversation
If users do not set the storage driver in their storage.conf, tools that use containers/storage will print a warning. Since we recommend that users should use "overlay" driver by default, we should set the settings in our default storage.conf. This ways distros that just grab the storage.conf in the storage library will work without the warning. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Member
Author
|
@nalind PTAL |
Member
|
LGTM |
Member
|
Change LGTM |
Member
|
Hi @TomSweeneyRedHat As overlayfs is the default storage driver from code this should be not influence of testing in rhel a lot for now. But it is good to have a record for such change in upstream from QE side. Thanks a lot for your reminding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If users do not set the storage driver in their storage.conf, tools that
use containers/storage will print a warning. Since we recommend that
users should use "overlay" driver by default, we should set the settings
in our default storage.conf. This ways distros that just grab the
storage.conf in the storage library will work without the warning.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com