test: system tests for Fedora compatibility #81
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the existing test suite by extracting common helper functions into a new tests/utils.sh file and significantly expands test coverage with several new integration scripts. These new tests cover various scenarios including delta paths, fuzzy renames, multiple old layers, source prefixes, and CLI error handling. Feedback highlights a potentially dangerous directory deletion in the Makefile, a bug in the sparse file creation logic within the utility script, and a portability improvement for temporary directory creation.
0b30b88 to
951b677
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 68.94% 75.60% +6.66%
==========================================
Files 10 10
Lines 1111 1111
==========================================
+ Hits 766 840 +74
+ Misses 232 159 -73
+ Partials 113 112 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2b52a50 to
88a378b
Compare
djach7
left a comment
There was a problem hiding this comment.
On the whole makes sense to me, but I think there might be a critical bug in the makefile.
kgiusti
left a comment
There was a problem hiding this comment.
Can you update the .gitignore file to include the temporary "test/" directory and the tar-diff/tar-patch executables in the top level directory:
$ git status
git status
On branch pr-81-testing
Untracked files:
(use "git add <file>..." to include in what will be committed)
tar-diff
tar-patch
test/
88a378b to
903b43c
Compare
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
903b43c to
ec0afd2
Compare
This PR is a sub-issue of the initial System tests PR #78.
Due to cross-platform compatibility issues encountered in the original PR, I am splitting the implementation by platform. This specific PR focuses on stabilizing and enabling the system tests for Fedora builds.
Subsequent PRs will be submitted for macOS and Windows platforms/architectures once this baseline is merged.
Relates to #78