test: replace tar alias with shell function for macOS compatibility#85
Merged
kgiusti merged 1 commit intocontainers:mainfrom May 6, 2026
Merged
test: replace tar alias with shell function for macOS compatibility#85kgiusti merged 1 commit intocontainers:mainfrom
kgiusti merged 1 commit intocontainers:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 72.87% 79.19% +6.31%
==========================================
Files 10 10
Lines 1412 1115 -297
==========================================
- Hits 1029 883 -146
+ Misses 271 134 -137
+ Partials 112 98 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates tests/utils.sh to replace the tar alias with a shell function when gtar is available. The review feedback suggests removing the export -f command to avoid unnecessary environment pollution and Bash-specific extensions, as the function is already available within the sourced script's context.
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
48f9bef to
de91302
Compare
kgiusti
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
taralias failing on previous macOS runs, this PR replaces it with thetar()shell function defined inuse_gnu_tar_if_available()which usesgtarinstead oftarif available.The previous
alias tar=gtardid not propagate inside the create_tar() function, causing it to use BSD tar instead of the required GNU tar.Closes #83