tests: Changed container image source for busybox#858
Merged
Conversation
|
Build failed.
|
Collaborator
Author
|
recheck |
|
Build succeeded.
|
martymichal
requested changes
Aug 9, 2021
martymichal
left a comment
martymichal
left a comment
Member
There was a problem hiding this comment.
The change looks alright. The reasoning behind switching from Docker to Quay is also fine. Apart from a single comment this looks good to go.
martymichal
added
2. Testing
Due to docker rate limiting we can not rely in docker.io for retrieving the images. This was detected when executing our tests for podman fedora gating pipeline. Our busybox image was not downloaded and one of the list tests was failing.
olivergs
force-pushed
the
toolbox-tests-busybox-quay
branch
from
a06ae4b to
198d9b3
Compare
|
Build failed.
|
martymichal
approved these changes
Aug 9, 2021
martymichal
left a comment
martymichal
left a comment
Member
There was a problem hiding this comment.
Looks alright. The test failure in Rawhide is unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to docker rate limiting we can not rely in docker.io for retrieving the images.
This was detected when executing our tests for podman fedora gating pipeline. Our busybox image was not downloaded and
one of the list tests was failing.