This repository was archived by the owner on Apr 3, 2018. It is now read-only.
test: move required test support files locally#660
Merged
sboeuf merged 4 commits intocontainers:masterfrom Mar 6, 2018
Merged
Conversation
added 3 commits
March 5, 2018 15:35
Rather than installing some parts we need into /tmp, install them into a tree-local directory. This is cleaner, and when you reboot your machine your install files will not get cleaned away. As the same time, only invoke sudo for the parts of the script we really need to, which keeps the file perms of the local parts more correct, and accessible by the user. Signed-off-by: Graham whaley <graham.whaley@intel.com>
Now we have the test support files being set up in a local dir, point the test code at them. Signed-off-by: Graham whaley <graham.whaley@intel.com>
Now we place the test support files in a local dir, update the api_test reference to use that path. Fixes: containers#645 Signed-off-by: Graham whaley <graham.whaley@intel.com>
Contributor
Author
|
Marked as DNM so we can discuss (so really an RFC).
I didn't realise we had some benchmarks ;-) I managed to run them with: $ sudo -E env PATH="$PATH" go test -bench=.It looks like we may have bitrotted though (as I suspect nobody runs these). The output I have from both the original and the modified-in-this-patch I get is: @sboeuf - something you think we should fix? Any idea how? |
sboeuf
reviewed
Mar 5, 2018
| mkdir -p ${tmpdir}/${virtcontainers_build_dir} | ||
|
|
||
| TMPDIR="/tmp" | ||
| TMPDIR="${SCRIPT_PATH}/supportfiles" |
Collaborator
There was a problem hiding this comment.
Could you add a commit adding this whole directory to .gitignore ? This way, we won't have git tracking those files that we could add to a patch by mistake.
Contributor
Author
There was a problem hiding this comment.
(oops, I meant to but forgot...) done and pushed
Add the test support files dir (utils/supportfiles) to gitignore, as we will never add those to the repo. Signed-off-by: Graham whaley <graham.whaley@intel.com>
sboeuf
approved these changes
Mar 5, 2018
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than have some of our required test support files live in
/tmp,let's install them in a local dir instead.