Setting notification-level to trace disables notifications

[piksel]

This is caused by the first check permitting "trace" as it's a valid logrus level:

watchtower/pkg/notifications/notifier.go

Lines 21 to 26 in 3369d24

	level, _ := f.GetString("notifications-level")
	logLevel, err := log.ParseLevel(level)
	if err != nil {
	log.Fatalf("Notifications invalid log level: %s", err.Error())
	}

...but then when grabbing all levels above it at:

watchtower/pkg/notifications/notifier.go

Line 27 in 3369d24

acceptedLogLevels := slackrus.LevelThreshold(logLevel)

it uses the AllLevels slice from slackrus, which doesn't contain Trace:
https://github.com/johntdyer/slackrus/blob/f7aae3243a0786c5a974bce71ed951c459876e64/levels.go#L8-L15

...which means that it will return an empty array of accepted levels:
https://github.com/johntdyer/slackrus/blob/f7aae3243a0786c5a974bce71ed951c459876e64/levels.go#L17-L25

[github-actions]

Hi there! 👋🏼 As you're new to this repo, we'd like to suggest that you read our code of conduct as well as our contribution guidelines. Thanks a bunch for opening your first issue! 🙏

[zoispag]

slackrus looks like it does not allow trace level.
We can make our own LevelThreshold method easily, thus making Trade level to not disable notifications, but are there any consequences to the legacy notifiers or shoutrrr?

How are the log levels used? I know that Info and Error give different attachment colors in the legacy slack for example. Would log.Trace work or would completely go nuts? :D

[piksel]

I doubt anyone REALLY wants anything below Info for normal use. But leaving it to the end user to decide if they want Debug is probably a good idea. Trace on the other hand is mainly used for credentials, which might not be apparent and not something you may want 3rd parties (notification services) to receive and/or keep a log of. I suggest we don't support setting the level that low.

To avoid important communication to get lost in a closed issues no one monitors, I'll go ahead and lock this issue. If you want to continue the discussion, please open a new issue. Thank you! 🙏🏼