Skip to content

chore: Update PR template#39

Merged
lusu007 merged 1 commit intomainfrom
chore/pr-template
Jul 16, 2024
Merged

chore: Update PR template#39
lusu007 merged 1 commit intomainfrom
chore/pr-template

Conversation

@meyfa
Copy link
Copy Markdown
Member

@meyfa meyfa commented Jul 16, 2024

Description

The "Description" header is removed so that GitHub places the commit message in the proper location. Otherwise, it has to be cut and pasted below the header manually.

The checklist is simplified - the first point was misleading, since changing the chart README.md would need a version bump. Also, a typo is fixed in the second point.

Additional Context

N/A

Checklist

  • The chart version in Chart.yaml has been updated according to semantic versioning (semver). This update is not required if the changes only impact README.md files.
  • All variables are document in the Chart's values.yaml and README.md files.
  • The pull request title meets the Conventional Commits specification and includes the chart name, for example: feat(chart-name): Add replica support

@meyfa meyfa requested a review from a team as a code owner July 16, 2024 15:26
The "Description" header is removed so that GitHub places the
commit message in the proper location. Otherwise, it has to be cut
and pasted below the header manually.

The checklist is simplified - the first point was misleading, since
changing the chart README.md *would* need a version bump. Also,
a typo is fixed in the second point.
@meyfa meyfa force-pushed the chore/pr-template branch from a448a93 to d9c7871 Compare July 16, 2024 16:01
@lusu007 lusu007 merged commit 93b7904 into main Jul 16, 2024
@lusu007 lusu007 deleted the chore/pr-template branch July 16, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants