[RTM] Skip folder DCs that are not database assisted in DcaExtractor#744
Merged
leofeyer merged 2 commits intocontao:hotfix/4.3.8from Apr 19, 2017
Merged
Conversation
Toflar
approved these changes
Mar 29, 2017
leofeyer
reviewed
Mar 29, 2017
| } | ||
|
|
||
| // Return if the DC type is "Folder" and is not database assisted | ||
| if ($GLOBALS['TL_DCA'][$this->strTable]['config']['dataContainer'] == 'Folder' && empty($GLOBALS['TL_DCA'][$this->strTable]['config']['databaseAssisted'])) |
Member
There was a problem hiding this comment.
I don't like the empty() check here (although it might be technically correct).
Member
Author
There was a problem hiding this comment.
Should I replace it with (!isset($GLOBALS['TL_DCA'][$this->strTable]['config']['databaseAssisted']) || !$GLOBALS['TL_DCA'][$this->strTable]['config']['databaseAssisted'])?
Member
There was a problem hiding this comment.
Probably just $GLOBALS['TL_DCA'][$this->strTable]['config']['databaseAssisted']? You have now added isset() to databaseAssisted but not to dataContainer …
Member
Author
There was a problem hiding this comment.
I thought dataContainer is a required field because there is no isset check 6 lines above. Wouldn’t removing the isset check result in “undefined index” notices?
discordier
approved these changes
Mar 29, 2017
leofeyer
added a commit
that referenced
this pull request
Sep 12, 2019
* Order the page models by the order of candidates (see #740) * Use FIND_IN_SET() directly * Add a unit test * Use ORDER BY FIELD() instead of FIND_IN_SET() * Simplify the findPages() method * Do not load the models separately * Run the CS fixer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install tool currently shows the deprecation message “Using database.sql files has been deprecated and will no longer work in Contao 5.0. Use a DCA file instead.” because it thinks
tl_templatesuses a database.sql file.With this PR
DC_Folders that are not database assisted get skipped in theDcaExtractor.