Skip to content

Feat: Small Builder/Reader capability additions#99

Merged
redaranj merged 3 commits into
contentauth:mainfrom
redaranj:feat/builder-reader-capabilities
Jul 1, 2026
Merged

Feat: Small Builder/Reader capability additions#99
redaranj merged 3 commits into
contentauth:mainfrom
redaranj:feat/builder-reader-capabilities

Conversation

@redaranj

Copy link
Copy Markdown
Member

Changes in this pull request

Adds three small Builder/Reader capabilities:

  • Builder.setBasePath (resolve relative resource references against a directory)
  • Builder/Reader.supportedMimeTypes introspection
  • Ingredient archive import/export

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • All applicable changes have been documented
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment

Additive Builder/Reader capabilities exposing previously-unwrapped FFI:

- Builder.setBasePath (GP-259): resolve relative resource references against a dir.
- Builder.supportedMimeTypes / Reader.supportedMimeTypes (GP-258): format introspection.
- Builder.writeIngredientArchive / addIngredientFromArchive (GP-257): compose
  ingredients across builders via archive round-tripping.

Wraps the corresponding c2pa_builder_*/c2pa_reader_* FFI through the JNI bridge,
with shared + Android instrumented tests.
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.71%. Comparing base (b5d0709) to head (c55a5a9).

Files with missing lines Patch % Lines
...ry/src/main/kotlin/org/contentauth/c2pa/Builder.kt 61.53% 1 Missing and 4 partials ⚠️
...ary/src/main/kotlin/org/contentauth/c2pa/Reader.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #99      +/-   ##
============================================
- Coverage     71.79%   71.71%   -0.08%     
  Complexity       38       38              
============================================
  Files            60       60              
  Lines          2255     2270      +15     
  Branches        260      266       +6     
============================================
+ Hits           1619     1628       +9     
- Misses          488      489       +1     
- Partials        148      153       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redaranj redaranj requested a review from scouten-adobe June 26, 2026 15:28
redaranj added 2 commits July 1, 2026 10:10
The 'Merge branch main' resolution dropped several lines, breaking the build:
- Builder.kt: missing '/**' opener before formatEmbeddable's KDoc.
- BuilderTests.kt: interleaved/dropped method bodies (testBuilderIngredientArchive
  tail, testBuilderArchiveErrorPaths body, spliced TestResult calls) — rebuilt the
  file as origin/main plus B's four added methods.
- AndroidBuilderTests.kt: missing closing brace + @test between
  runTestBuilderArchiveErrorPaths and the next runner.

All modules (release/debug/test-shared/androidTest/test-app) and the JNI C now
compile.
@redaranj redaranj merged commit 18511d4 into contentauth:main Jul 1, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants