fix: salesforce commerce cloud when there is a untitled product listing from salesforce [INTEG-3036]#10070
Merged
ryunsong-contentful merged 1 commit intomasterfrom Aug 19, 2025
Merged
Conversation
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
…ng from salesforce
786b129 to
2be80ca
Compare
Adrian Meyer (primeinteger)
approved these changes
Aug 19, 2025
Contributor
Adrian Meyer (primeinteger)
left a comment
There was a problem hiding this comment.
Approving so this doesn’t block the main fix.
One small note from the screenshots: the modal design could be tightened up a bit. There seems to be extra padding in the modal content area that slightly throws off the overall layout. Not a blocker, but maybe worth refining later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
JIRA Link: https://contentful.atlassian.net/browse/INTEG-3036
Zendesk link: https://contentful.atlassian.net/browse/ZEND-6790
User noted an issue in zendesk

With the fix it now does this

Root Cause
The error was caused by unsafe property access patterns where
.defaultproperties were accessed without proper null/undefined checks:Solution
1. Implemented Safe Property Access
Replaced unsafe property access with optional chaining (
?.) and nullish coalescing (||) operators:2. Fixed Modal UI Structure