Bulk-Edit-App: Changing the spinner for a skeleton [INTEG-3104] #10081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliRossi
approved these changes
Aug 26, 2025
Collaborator
JuliRossi
left a comment
JuliRossi
left a comment
There was a problem hiding this comment.
Looks good! I'd ask erin if 5 columns for the skeleton is the way to go before merging
Collaborator
Author
After asking Erin, she said it looks fine! So I'll proceed merging the PR! 👍 |
JuliRossi
added a commit
that referenced
this pull request
Sep 2, 2025
* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076) * freeze top row with Field Names * removing unused import * Bulk-Edit-App: Changing the spinner for a skeleton [INTEG-3104] (#10081) * changing the spinner for a skeleton * rename css style * making the status column sticky too (#10082) * Bulk edit [INTEG-2847] (#10074) * Enhance performance and reduce errors by batching * Adding create-entries and delete-entries v1 scripts * Fixing cors size limitation * moving scripts * Minor fixes * Tests and refactor * Update .env.example to clarify optional entry count setting * Fixing truncation for some really big texts * Adding delete-entries modifications and tests * generation with numbers of entries * batching for getting large entries * simplifying a bit * disabling cancel botton when undoing and saving * Set truncate to 30 * Fixing config files * making test better and simpler * remove duplication * making adjustments base on comments * Refactor entry fetching to handle batch sizes and improve response limits --------- Co-authored-by: francobanfi <franco.banfi@external.contentful.com> * Bulk-Edit-App: Show the progress of the edition [INTEG-3106] (#10085) * adding progress in modal and tests * formating with prettier * creating generic progress component + styling + tests * formating with prettier * using existing note component * upload script (#10086) * Bulk-Edit-App: Adding progress note in undo update [INTEG-3112] (#10087) * Adding progress note in undo update * Update apps/bulk-edit/src/locations/Page/components/UndoBulkEditModal.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Franco Banfi <62450599+FBanfi@users.noreply.github.com> Co-authored-by: francobanfi <franco.banfi@external.contentful.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ryunsong-contentful
pushed a commit
that referenced
this pull request
Sep 3, 2025
* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076) * freeze top row with Field Names * removing unused import * Bulk-Edit-App: Changing the spinner for a skeleton [INTEG-3104] (#10081) * changing the spinner for a skeleton * rename css style * making the status column sticky too (#10082) * Bulk edit [INTEG-2847] (#10074) * Enhance performance and reduce errors by batching * Adding create-entries and delete-entries v1 scripts * Fixing cors size limitation * moving scripts * Minor fixes * Tests and refactor * Update .env.example to clarify optional entry count setting * Fixing truncation for some really big texts * Adding delete-entries modifications and tests * generation with numbers of entries * batching for getting large entries * simplifying a bit * disabling cancel botton when undoing and saving * Set truncate to 30 * Fixing config files * making test better and simpler * remove duplication * making adjustments base on comments * Refactor entry fetching to handle batch sizes and improve response limits --------- Co-authored-by: francobanfi <franco.banfi@external.contentful.com> * Bulk-Edit-App: Show the progress of the edition [INTEG-3106] (#10085) * adding progress in modal and tests * formating with prettier * creating generic progress component + styling + tests * formating with prettier * using existing note component * upload script (#10086) * Bulk-Edit-App: Adding progress note in undo update [INTEG-3112] (#10087) * Adding progress note in undo update * Update apps/bulk-edit/src/locations/Page/components/UndoBulkEditModal.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Franco Banfi <62450599+FBanfi@users.noreply.github.com> Co-authored-by: francobanfi <franco.banfi@external.contentful.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We needed to change the spinner loader for a skeleton.
Approach
Used the Skeleton component from forma. Needed to wrap it up inside a table so the styles were applied to the skeleton correctly.
Testing steps
Grabacion.de.pantalla.2025-08-26.a.la.s.12.24.38.p.m.mov
Breaking Changes
N/A
Dependencies and/or References
Link to INTEG-3014
Deployment
N/A