Bulk edit: Insert columns in initial order after filtering [MAPS-41]#10139
Merged
Joaquin (joaquincasal) merged 1 commit intomasterfrom Sep 30, 2025
Merged
Bulk edit: Insert columns in initial order after filtering [MAPS-41]#10139Joaquin (joaquincasal) merged 1 commit intomasterfrom
Joaquin (joaquincasal) merged 1 commit intomasterfrom
Conversation
Contributor
ryunsong-contentful
left a comment
ryunsong-contentful
left a comment
There was a problem hiding this comment.
Looking at this PR to review the column ordering implementation...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Right now if you deselect a column and add it again, it will be added at the end of the table instead of its original position
Approach
Every time we insert a column into the selectedColumns state, we reorder it
Testing steps
Remove and add a column from the columns filter
Screen.Recording.2025-09-30.at.10.08.08.mov