Skip to content

Conversation

@FBanfi
Copy link
Collaborator

@FBanfi FBanfi commented Oct 21, 2025

Purpose

This update fixes a few test failures in the EntryTable.test.tsx and Page.test.tsx files that went unnoticed during the CI runs in previous reviews for v1.4.

Approach

  • The useVirtualizer hook is now mocked, the virtualizer need a proper container height to determine which items to render. In the test environment, the scroll container didn't have a defined height, so the virtualizer didn't render any items.
  • The edit button is now shown even if there aren't selected fields, so that test was also changed.

Testing steps

N/A

Breaking Changes

N/A

Dependencies and/or References

Link to MAPS-77.

Deployment

N/A

@FBanfi FBanfi requested a review from a team as a code owner October 21, 2025 19:45
Copy link
Contributor

@ryunsong-contentful ryunsong-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Good job catching this issue

@FBanfi FBanfi merged commit 431eee0 into master Oct 22, 2025
16 checks passed
@FBanfi FBanfi deleted the bulk-edit-fix-tests branch October 22, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants