[INTEG-3250] Google Docs App skeleton#10227
Merged
ryunsong-contentful merged 3 commits intomasterfrom Nov 7, 2025
Merged
Conversation
ryunsong-contentful
changed the title
ryunsong-contentful
force-pushed
the
INTEG-3250
branch
8 times, most recently
from
36dc81f to
2f03e0e
Compare
ryunsong-contentful
force-pushed
the
INTEG-3250
branch
from
2f03e0e to
be34d3c
Compare
Adrian Meyer (primeinteger)
approved these changes
Nov 4, 2025
Contributor
Adrian Meyer (primeinteger)
left a comment
Adrian Meyer (primeinteger)
left a comment
There was a problem hiding this comment.
Looks like a great start! I added a few comments about some minor things that jumped out at me.
| "preview": "vite preview", | ||
| "test": "vitest", | ||
| "create-app-definition": "contentful-app-scripts create-app-definition", | ||
| "deploy": "contentful-app-scripts upload --ci --bundle-dir ./build --organization-id ${DEFINITIONS_ORG_ID} --definition-id {3EaGZUMKRKVZUyrcoNJ4o4} --token ${CONTENTFUL_CMA_TOKEN}", |
Contributor
There was a problem hiding this comment.
Is this a real app def id in the deploy script? I dont think it needs to be surrounded in curly braces.
| "upload-ci": "contentful-app-scripts upload --ci --bundle-dir ./build --organization-id $CONTENTFUL_ORG_ID --definition-id $CONTENTFUL_APP_DEF_ID --token $CONTENTFUL_ACCESS_TOKEN", | ||
| "upsert-actions": "contentful-app-scripts upsert-actions --ci --organization-id $CONTENTFUL_ORG_ID --definition-id $CONTENTFUL_APP_DEF_ID --token $CONTENTFUL_ACCESS_TOKEN", | ||
| "build:functions": "contentful-app-scripts build-functions --ci", | ||
| "deploy:dev": "source .env && contentful-app-scripts upload --ci --bundle-dir ./build --organization-id \"$DEFINITIONS_ORG_ID\" --definition-id {653vTnuQw3j5onU1tUoH6t} --token \"$CONTENTFUL_CMA_TOKEN\"", |
Contributor
There was a problem hiding this comment.
Is this a real app def id in the deploy:dev script? I dont think it needs to be surrounded in curly braces here either.
| }, | ||
| { | ||
| "id": "prompt", | ||
| "name": "Prompt fromt he user", |
Contributor
There was a problem hiding this comment.
Typo in the prompt name 👀
| { | ||
| "id": "prompt", | ||
| "name": "Prompt fromt he user", | ||
| "type": "String", |
Contributor
There was a problem hiding this comment.
Should the prompt type be Symbol here?
Comment on lines
+16
to
+21
| interface ContentTypeParserConfig { | ||
| openaiApiKey: string; | ||
| modelVersion: string; | ||
| jsonData: any; | ||
| document: any; | ||
| } |
Contributor
There was a problem hiding this comment.
Should this type be named DocumentParserConfig instead? The content type parser function already has an interface with this name.
ryunsong-contentful
added a commit
that referenced
this pull request
Nov 7, 2025
* feat: initialize google-docs app * feat: add functions and backend for google-docs * feat: fill out instructions and jira ticket numbers to the backend function skeleton for google-docs
ryunsong-contentful
added a commit
that referenced
this pull request
Nov 7, 2025
* feat: initialize google-docs app * feat: add functions and backend for google-docs * feat: fill out instructions and jira ticket numbers to the backend function skeleton for google-docs
ryunsong-contentful
added a commit
that referenced
this pull request
Nov 10, 2025
* [INTEG-3250] Google Docs App skeleton (#10227) * feat: initialize google-docs app * feat: add functions and backend for google-docs * feat: fill out instructions and jira ticket numbers to the backend function skeleton for google-docs * fix: google doc skeleton issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Function Backend
apps/google-docs/functions/createEntriesFromDocument.tsFrontend
Before Merging