Skip to content

feat(google-docs): add select entries functionality to preview modal[INTEG-3348]#10527

Merged
Harika Kondur (harikakondur) merged 9 commits intomasterfrom
integ-3348-select-entries
Feb 5, 2026
Merged

feat(google-docs): add select entries functionality to preview modal[INTEG-3348]#10527
Harika Kondur (harikakondur) merged 9 commits intomasterfrom
integ-3348-select-entries

Conversation

@harikakondur
Copy link
Copy Markdown
Contributor

@harikakondur Harika Kondur (harikakondur) commented Feb 4, 2026

Purpose

google docs app: added checkboxes in the preview modal to select which entries get created

Approach

since we are not using existing content and always creating new entries, we should give users the opportunity to remove the ones they don’t need.

Testing screenshots

Screenshot 2026-02-04 at 12 16 35 PM Screenshot 2026-02-04 at 12 16 20 PM Screenshot 2026-02-04 at 12 16 30 PM
Screen.Recording.2026-02-05.at.8.36.54.AM.mov
  • worked when I removed authors from preview (required reference field for blogPost ct)
Screen.Recording.2026-02-04.at.11.50.43.AM.mov

@harikakondur Harika Kondur (harikakondur) requested a review from a team as a code owner February 4, 2026 18:58
Comment on lines +57 to +61
<Checkbox
isChecked={isChecked}
onChange={() => onToggleEntry(index)}
id={`entry-${index}`}
/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making the entire box container clickable to toggle the entry selection?

I think it's nice when checkboxes allow you click the text next to them to toggle the selection. In this case since there's a box container, the entire thing could be a click target for checking/unchecking the checkbox.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love that idea, will make some changes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched to the Card component, it has built-in hover styles

Screen.Recording.2026-02-05.at.8.36.54.AM.mov

primeinteger

This comment was marked as off-topic.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code ✨ and nice use of design tokens throughout the styling 🔥

import { Button, Modal, Paragraph } from '@contentful/f36-components';
import { EntryToCreate } from '../../../../../../functions/agents/documentParserAgent/schema';
import tokens from '@contentful/f36-tokens';
import { PreviewEntryList } from './PreviewEntryList';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note: there is a circular import here (PreviewModal <--> PreviewEntryList via PreviewEntry). It works because TypeScript erases types at runtime.

Consider extracting PreviewEntry into a shared types.ts file and importing it in both components. This would avoid the circular dependency between PreviewModal and PreviewEntryList.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@harikakondur Harika Kondur (harikakondur) merged commit b77a3cd into master Feb 5, 2026
15 checks passed
@harikakondur Harika Kondur (harikakondur) deleted the integ-3348-select-entries branch February 5, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants